sebastianliu commented on pull request #14748: URL: https://github.com/apache/flink/pull/14748#issuecomment-769053106
Thx a lot for the review and suggestion @wuchong , I have refined the javadoc and updated some limitations. For the `Collation` semantic, as we haven't passed the relevant conditions in the `WITHIN GROUP` clause to the aggregate function at present. I think the `AggregateExpression` could exclude the `OrderExpression` for the moment. After the aggregate function can get the order conditions, I can design the `OrderExpression` and add it back. Look forward for the further progress. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
