zentol commented on a change in pull request #63:
URL: https://github.com/apache/flink-docker/pull/63#discussion_r564741013
##########
File path: add-version.sh
##########
@@ -112,9 +112,9 @@ for source_variant in "${SOURCE_VARIANTS[@]}"; do
flink_url_file_path=flink/flink-${flink_version}/flink-${flink_version}-bin-scala_${scala_version}.tgz
-
flink_tgz_url="https://www.apache.org/dyn/closer.cgi?action=download&filename=${flink_url_file_path}";
+
flink_tgz_url="https://archive.apache.org/dist/${flink_url_file_path}";
Review comment:
It is highly frowned upon to download anything related to recent
releases from the archive.
Now, for 1.12.0 this would be _fine_, but for 1.12.1 it should still work
against the mirrors.
That said, I'm not sure what the behavior would be a year down the line. Is
that what you're alluding to?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
