[ 
https://issues.apache.org/jira/browse/FLINK-21144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271981#comment-17271981
 ] 

Xintong Song commented on FLINK-21144:
--------------------------------------

Nice catch!

This escaped our tests because we use a fully implemented executor in the tests.

I think the proper fix might be to implement the missing methods in 
`MainThreadExecutor`. Per the error message, there're no strong reason against 
implementing those methods, except for there were not used. And we might also 
want to do that for the master branch, to avoid similar problems in future.

> KubernetesResourceManagerDriver#tryResetPodCreationCoolDown causes fatal error
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-21144
>                 URL: https://issues.apache.org/jira/browse/FLINK-21144
>             Project: Flink
>          Issue Type: Bug
>          Components: Deployment / Kubernetes
>    Affects Versions: 1.12.1
>            Reporter: Yang Wang
>            Priority: Major
>             Fix For: 1.12.2
>
>
> {{KubernetesResourceManagerDriver#tryResetPodCreationCoolDown}} is calling a 
> not implemented method {{RpcEndpoint.MainThreadExecutor#schedule(Callable<V> 
> callable, long delay, TimeUnit unit)}}. This will cause a fatal error and 
> make JobManager terminate exceptionally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to