SteNicholas opened a new pull request #14742:
URL: https://github.com/apache/flink/pull/14742


   ## What is the purpose of the change
   
   *The configuration `parallelism.default` for table environment doesn't take 
effect for `TableEnvironment#explain`. Because `PlannerBase#translateToRel` 
doesn't invoke `overrideEnvParallelism` which configures the configuration into 
underlying `StreamExecutionEnvironment` and is invoked in `translate`. Method 
`overrideEnvParallelism` should be invoked in `translateToRel` and removed from 
`translate`.*
   
   ## Brief change log
   
     - *`PlannerBase#translateToRel` invokes the method 
`overrideEnvParallelism` which configures the configuration into underlying 
`StreamExecutionEnvironment`.*
   
   ## Verifying this change
   
     - *Modify `testStreamTableEnvironmentExecutionExplain` of 
`TableEnvironmentTest` to verify the test case whether the configuration 
`parallelism.default` takes effect in `TableEnvironment#explainSql` or not.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to