rkhachatryan commented on a change in pull request #14662: URL: https://github.com/apache/flink/pull/14662#discussion_r560387311
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/messages/checkpoint/SerializedCheckpointException.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.messages.checkpoint; + +import org.apache.flink.runtime.checkpoint.CheckpointException; +import org.apache.flink.runtime.checkpoint.CheckpointFailureReason; +import org.apache.flink.util.SerializedThrowable; + +import java.io.Serializable; + +/** + * Serialized checkpoint exception which wraps the checkpoint failure reason and its serialized + * throwable. + */ +public class SerializedCheckpointException implements Serializable { + private static final long serialVersionUID = 1L; + + private final CheckpointFailureReason checkpointFailureReason; + private final SerializedThrowable serializedThrowable; Review comment: I couldn't find any usages of this field. It's unclear to me who is responsible for calling `deserializeError`. IIUC, it's not usable before this call. Maybe just drop this field? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
