tillrohrmann commented on a change in pull request #14666:
URL: https://github.com/apache/flink/pull/14666#discussion_r558462987
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -275,7 +275,9 @@ public void killCluster(String clusterId) throws
FlinkException {
try {
client.stopAndCleanupCluster(clusterId);
} catch (Exception e) {
- client.handleException(e);
+ LOG.error(
+ "An exception occurred while stopping the Kubernetes
cluster and cleaning up.",
+ e);
Review comment:
Same here.
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -118,7 +118,7 @@ public String getClusterDescription() {
HighAvailabilityServicesUtils.AddressResolution
.TRY_ADDRESS_RESOLUTION)));
} catch (Exception e) {
- client.handleException(e);
+ LOG.error("An exception occurred while instantiating the
RestClusterClient.", e);
Review comment:
Are you sure that we need these log statements? I think this is only
required if the `RuntimeException` is nowhere logged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
