zentol commented on a change in pull request #14630:
URL: https://github.com/apache/flink/pull/14630#discussion_r556656134



##########
File path: flink-dist/src/main/flink-bin/bin/docker-entrypoint.sh
##########
@@ -0,0 +1,161 @@
+#!/usr/bin/env bash

Review comment:
       there's a lot of stuff in bin/ at this point that users should never use 
directly (bash-java-utils, config.sh, flink-console.sh, flink-daemon.sh, 
find-flink-home.sh), that I'm not too concerned about adding one more.
   I see the point of trying to hide it, but this whole 
"put-into-opt-but-load-it-automatically-in-some-scenarios" business that the 
table-api introduced is rubbing me the wrong way.
   The overall semantics for bin/opt seem rather ill-defined.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to