[GitHub] [flink] hwanju commented on a change in pull request #14499: [FLINK-15156] Warn user if System.exit() is called in user code

[GitBox]

hwanju commented on a change in pull request #14499:
URL: https://github.com/apache/flink/pull/14499#discussion_r555381736



##########
File path: 
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java
##########
@@ -210,7 +211,12 @@ public String getDescription() throws 
ProgramInvocationException {
      * local execution by default.
      */
     public void invokeInteractiveModeForExecution() throws 
ProgramInvocationException {
-        callMainMethod(mainClass, args);
+        FlinkUserSecurityManager.monitorSystemExitForCurrentThread();

Review comment:
       IIUC, it's okay not to have `FlinkUserSecurityManager` in `CliFrontend`, 
as our focus is more on JM like crashing Flink cluster itself. Do you want me 
to also apply this monitoring to CliFrontend? Currently, I have not done it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org