cvasii commented on a change in pull request #13994:
URL: https://github.com/apache/flink/pull/13994#discussion_r552749908
##########
File path:
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/utils/ParquetSchemaConverter.java
##########
@@ -306,6 +295,18 @@ public static MessageType toParquetType(TypeInformation<?>
typeInformation, bool
return typeInfo;
}
+ private static ObjectArrayTypeInfo
convertGroupElementToArrayTypeInfo(GroupType arrayFieldType, GroupType
elementType) {
+ for (Type type : elementType.getFields()) {
+ if (!type.isRepetition(Type.Repetition.REQUIRED)) {
+ throw new UnsupportedOperationException(
Review comment:
Why this check? What's wrong with having a list of complex elements,
whose fields are not all required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
