rkhachatryan commented on a change in pull request #14546:
URL: https://github.com/apache/flink/pull/14546#discussion_r551614695



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -297,6 +297,11 @@ public void checkpointState(
         try {
             if (takeSnapshotSync(
                     snapshotFutures, metadata, metrics, options, 
operatorChain, isCanceled)) {
+                LOG.debug(
+                        "Is unaligned checkpoint for task {} : {}",

Review comment:
       I think a better place to log is the end of `takeSnapshotSync` where 
other properties are logged.

##########
File path: 
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.html
##########
@@ -91,6 +91,7 @@
         <th nzSortKey="alignment.processed" nzShowSort><strong>Processed 
(persisted) Data</strong></th>
         <th nzSortKey="alignment.duration" nzShowSort><strong>Alignment 
Duration</strong></th>
         <th nzSortKey="start_delay" nzShowSort><strong>Start 
Delay</strong></th>
+        <th nzSortKey="unaligned_checkpoint" nzShowSort><strong>Unaligned 
Checkpoint</strong></th>

Review comment:
       nit: invert to Aligned to save space?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to