NickBurkard commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r551018720
##########
File path: pom.xml
##########
@@ -822,53 +822,6 @@ under the License.
</dependencyManagement>
<profiles>
- <profile>
- <id>scala-2.11</id>
- <properties>
- <scala.version>2.11.12</scala.version>
-
<scala.binary.version>2.11</scala.binary.version>
- </properties>
- <activation>
- <property>
- <name>!scala-2.12</name>
- </property>
- </activation>
- <!-- Scala Shell doesn't currently work with Scala 2.12
so only include
- when building for Scala 2.11. -->
- <modules>
- <module>flink-scala-shell</module>
- </modules>
Review comment:
I noticed that `flink-scala-shell` does not support Scala 2.12 yet. I
just removed the conditional compilation, the module remains. It looks like
https://github.com/apache/flink/pull/11895 addresses this but is still
in-progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
