rkhachatryan commented on a change in pull request #14509: URL: https://github.com/apache/flink/pull/14509#discussion_r549688436
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInput.java ########## @@ -73,21 +72,20 @@ private final DeserializationDelegate<StreamElement> deserializationDelegate; - private final RecordDeserializer<DeserializationDelegate<StreamElement>>[] recordDeserializers; + private final Map<InputChannelInfo, RecordDeserializer<DeserializationDelegate<StreamElement>>> Review comment: Yes, once per buffer. Moreover, map access was already there before: ``` private void processBuffer(BufferOrEvent bufferOrEvent) throws IOException { lastChannel = channelIndexes.get(bufferOrEvent.getChannelInfo()); ``` so it shouldn't make any difference. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org