tillrohrmann commented on pull request #14495:
URL: https://github.com/apache/flink/pull/14495#issuecomment-751661740


   I think the enum pattern is used here in order to prevent that someone 
instantiates the `HistoryServerUtils` class. Hence, I am sceptical about the 
benefit of this change here. If we want to change it, then we should at least 
make the constructor private or let it throw an exception which prevents 
instantiating this class. But I am wondering whether spending time on this 
issue is worth it. I would be in favour of closing this PR if you are ok with 
it @zhisheng17.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to