HuangZhenQiu commented on a change in pull request #8952: URL: https://github.com/apache/flink/pull/8952#discussion_r547769505
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/failurerate/NoFailureRater.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.failurerate; + +import org.apache.flink.metrics.MeterView; +import org.apache.flink.util.clock.Clock; + +/** + * No failure rater only records to the per second rate for metrics reporting. Thus, its functionality falls back to + * a MeterView. + */ +public class NoFailureRater extends MeterView implements FailureRater { + + public NoFailureRater(int timeSpanInSeconds) { + super(timeSpanInSeconds); + } + + @Override + public boolean exceedsFailureRate() { + return false; + } + + @Override + public void markFailure(Clock clock) { + markEvent(clock.absoluteTimeMillis()); Review comment: Good catch. Revised accordingly. We need clock in the interface, so that It is easier for us to simulate the time changes in test cases. Please check TimestampBasedFailureRaterTest. ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/failurerate/TimestampBasedFailureRater.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.failurerate; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.util.clock.Clock; + +import java.util.ArrayDeque; + +/** + * A timestamp queue based failure rater implementation. + */ +public class TimestampBasedFailureRater implements FailureRater { + private static final int DEFAULT_TIMESTAMP_SIZE = 300; + private static final Double MILLISECONDS_PER_SECOND = 1000.0; + private final int maximumFailureRate; + private final Time failureInterval; + private final ArrayDeque<Long> failureTimestamps; Review comment: Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
