wangyang0918 commented on pull request #14447:
URL: https://github.com/apache/flink/pull/14447#issuecomment-749928782


   @blublinsky I think what till means is to introduce a common config option 
for service account. It could be `kubernetes.service-account`. It should only 
take effect when the jobmanager/taskmanager specific config option is not 
configured.
   
   Then the `KubernetesJobManagerParameters#getServiceAccount()` could be like 
following. Same is for `KubernetesTaskManagerParameters`.
   ```
   public String getServiceAccount() {
       return 
flinkConfig.getOptional(KubernetesConfigOptions.JOB_MANAGER_SERVICE_ACCOUNT)
        .orElse(flinkConfig.getString(KubernetesConfigOptions.SERVICE_ACCOUNT));
   }
   ```
   
   Moreover, we need a test for such fallback logics.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to