tillrohrmann commented on a change in pull request #14465:
URL: https://github.com/apache/flink/pull/14465#discussion_r547348834
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphPartitionReleaseTest.java
##########
@@ -179,10 +176,10 @@ private SchedulerBase createScheduler(
final JobVertex... vertices) throws Exception {
final JobGraph jobGraph = new JobGraph(new JobID(), "test job",
vertices);
- final SlotProvider slotProvider = new TestingSlotProvider(
- ignored -> CompletableFuture.completedFuture(new
TestingLogicalSlotBuilder().createTestingLogicalSlot()));
- final SchedulerBase scheduler = SchedulerTestingUtils
- .newSchedulerBuilderWithDefaultSlotAllocator(jobGraph,
slotProvider, Time.seconds(10))
+ final SchedulerBase scheduler =
SchedulerTestingUtils.newSchedulerBuilder(jobGraph)
+
.setExecutionSlotAllocatorFactory(SchedulerTestingUtils.slotSharingExecutionSlotAllocatorFactoryBuilder()
Review comment:
Can't this be the default? Or is it the custom allocation timeout we are
setting here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
