wangxlong commented on a change in pull request #14280:
URL: https://github.com/apache/flink/pull/14280#discussion_r547295921
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/FirstValueAggFunction.java
##########
@@ -107,6 +107,27 @@ public void accumulate(RowData rowData, StringData value,
Long order) {
}
}
+ public void merge(RowData acc, Iterable<RowData> its) {
+ GenericRowData accRowData = (GenericRowData) acc;
+ long accOrder = accRowData.getLong(1);
+ GenericRowData firstAcc = accRowData;
+ boolean needUpdate = false;
+
+ for (RowData rowData : its) {
Review comment:
For it's not using the remove method, so It's ok to use that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
