rkhachatryan commented on a change in pull request #14057:
URL: https://github.com/apache/flink/pull/14057#discussion_r544868039



##########
File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/AlternatingControllerTest.java
##########
@@ -68,6 +68,22 @@
  */
 public class AlternatingControllerTest {
 
+       /**
+        * Upon subsuming (or canceling) a checkpoint, channels should be 
notified regardless of whether UC controller is
+        * currently being used or not. Otherwise, channels may capture 
in-flight buffers from an older checkpoint.

Review comment:
       Sorry, my bad, I didn't update the comment after updating the test. 
   It checks whether the buffer (on the other channel) was captured or not. 
I'll update the comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to