Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1790#discussion_r56160873
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -781,6 +787,32 @@ class TaskManager(
}
}
+ private def handleRequestTaskManagerLog
+ (sender: ActorRef, requestType: LogTypeRequest, jobManager: ActorRef):
+ Unit = {
+ if (blobService.isDefined && jobManager.path.address.host.isDefined) {
--- End diff --
If the `blobService` is defined the `jobManager` should have a defined
address as well. I think it would be better to use pattern matching to extract
the blobService from the `Option`. This is more scalaesque.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
