godfreyhe opened a new pull request #14360: URL: https://github.com/apache/flink/pull/14360
## What is the purpose of the change *Refactor verifyPlan method in TableTestBase as following: 1. keep verifyPlan method, which will print planBefore, planMiddle and planAfter. planBefore is original (un-optimized) logical plan, corresponding to Abstract Syntax Tree item in the explain result; planMiddle is the optimized physical plan, corresponding to Optimized Physical Plan item in the explain result. and ESTIMATED_COST and CHANGELOG_MODE could be applied on physical plan; planAfter is the optimized execution plan, corresponding to Optimized Execution Plan item in the explain result. see https://issues.apache.org/jira/browse/FLINK-20478 for more details about explain refactor 2. add verifyRelPlan method, which will print planBefore and planAfter. planBefore is original (un-optimized) logical plan, planAfter is the optimized physical plan. We could use this method to check the rule tests and the tests that only care about the calcite optimized result, such as ESTIMATED_COST and CHANGELOG_MODE 3. add verifyExecPlan method, which will print planBefore and planAfter. planBefore is original (un-optimized) logical plan, planAfter is the optimized execution plan. currently, most test case will use this method to verify the plan, such as JoinTest, CalcTest, etc.* ## Brief change log - *Refactor verifyPlan method and update the related tests* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
