StephanEwen commented on pull request #14314: URL: https://github.com/apache/flink/pull/14314#issuecomment-739566306
Looks good, +1 to merge. A quick thought on the testing code: In my experience, the pattern where the verification is built into the mocks (especially shared mocks) tends to be less reusable in the long run, and tends to mix up concerns between tests. I found it more maintainable to build reusable mocks that capture/record state and actions and assert on the state. It is not something we need to change here, because much code in the source already uses the pattern here. Just a suggestion for future PRs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
