[ 
https://issues.apache.org/jira/browse/FLINK-20324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238889#comment-17238889
 ] 

Boris Lublinsky commented on FLINK-20324:
-----------------------------------------

Thank you Yang Wang,

Digging a bit deeper in your answers:

Env variables.

I see documentation, but I do not see its implementation in the code. I would 
assume those are implemented as decorators, but the only thing that I see there 
is an EnvSecretsDecorator, which seems to take these env variables from secrets:


public static final ConfigOption<List<Map<String, String>>> 
KUBERNETES_ENV_SECRET_KEY_REF =
 key("kubernetes.env.secretKeyRef")
 .mapType()
 .asList()
 .noDefaultValue()
 .withDescription(
 Description.builder()
 .text("The user-specified secrets to set env variables in Flink container. The 
value should be in " +
 "the form of %s.", 
TextElement.code("env:FOO_ENV,secret:foo_secret,key:foo_key;env:BAR_ENV,secret:bar_secret,key:bar_key"))
 .build());

Which is not exactly that I was proposing. Also it always sets the same 
environment on both Job and Task manager. Do we want this or we want to 
distinguish between the two?

I could not find a single example, so I am probably missing something here.

 

Mounting secrets looks good, but not allowing to distinguish between Job and 
Task manager. Is this correct?

I also looked at FLINK-15649 and it seems to be postponed. Is there any 
progress for it?

 

Finally a new ticket 
[https://issues.apache.org/jira/projects/FLINK/issues/FLINK-20359?filter=reportedbyme]
 is created

 

 

 

> Support  customizing of containers for native kubernetes setup
> --------------------------------------------------------------
>
>                 Key: FLINK-20324
>                 URL: https://issues.apache.org/jira/browse/FLINK-20324
>             Project: Flink
>          Issue Type: New Feature
>          Components: Deployment / Kubernetes
>    Affects Versions: 1.11.2
>         Environment: Kubernetes
>            Reporter: Boris Lublinsky
>            Priority: Major
>             Fix For: 1.12.0, 1.11.2
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> A common requirement for Flink applications is usage of custom resources 
> (Environment variables, PVCs, Secrets, configMaps, etc). For example, usage 
> of NFS-based checkpointing, require mounting NFS volumes, access to databases 
> might require environment variables and secrets, the ability to safely remove 
> cluster manager deployment might require owner's reference, etc.
> All of these resources can be added to created pods using Pod decorators 
> already defined by Flink. So implementation of such support is as simple as 
> implementing of new decorators and wiring them correctly to the appropriate 
> factories.
>  
> An implementation of such support is provided in this pull request 
> [https://github.com/apache/flink/pull/14005]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to