StephanEwen edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-733673544
The change to `JobConfWrapper` looks good.
For the `SerializableWrapper` - have you considered reusing
`SerializedValue`
It is a similar, but serializes eagerly and deserializes lazily, which has
a few advantages:
- It makes it easier to supply a custom classloader when needed
- Exceptions occur in the code that writes/access the value, not in the
JavaSerialization stack. That is much easier to understand for users and to
debug for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
