dawidwys commented on a change in pull request #14085:
URL: https://github.com/apache/flink/pull/14085#discussion_r530239188
##########
File path:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/RowDataToAvroConverters.java
##########
@@ -67,13 +67,28 @@ public static RowDataToAvroConverter
createConverter(LogicalType type) {
final RowDataToAvroConverter converter;
switch (type.getTypeRoot()) {
case NULL:
- converter = (schema, object) -> null;
+ converter = new RowDataToAvroConverter() {
Review comment:
Yes, the test should fail, unless only a converter for DataType that is
not used in the test is updated.
I added a comment there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
