aljoscha commented on a change in pull request #14085:
URL: https://github.com/apache/flink/pull/14085#discussion_r530208152
##########
File path: flink-end-to-end-tests/pom.xml
##########
@@ -89,6 +89,16 @@ under the License.
<module>flink-end-to-end-tests-hbase</module>
</modules>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>net.java.dev.jna</groupId>
Review comment:
This is for dependency convergence, right? So we should add a comment to
say for which projects in case someone is wondering in the future.
##########
File path:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/RowDataToAvroConverters.java
##########
@@ -67,13 +67,28 @@ public static RowDataToAvroConverter
createConverter(LogicalType type) {
final RowDataToAvroConverter converter;
switch (type.getTypeRoot()) {
case NULL:
- converter = (schema, object) -> null;
+ converter = new RowDataToAvroConverter() {
Review comment:
These changes are because shading doesn't work with lambdas, right? Just
putting it here in case someone else is wondering in the future.
It might be worth putting a comment above this section that explains it,
otherwise someone else might replace these by lambdas in the future. But then
the tests would fail, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
