gaoyunhaii commented on a change in pull request #14116:
URL: https://github.com/apache/flink/pull/14116#discussion_r530189998
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/stream/StreamingFileWriter.java
##########
@@ -134,13 +143,19 @@ public void notifyCheckpointComplete(long checkpointId)
throws Exception {
private void commitUpToCheckpoint(long checkpointId) throws Exception {
helper.commitUpToCheckpoint(checkpointId);
+
+ NavigableMap<Long, Set<String>> newPartitions =
this.newPartitions.headMap(checkpointId, true);
+ Set<String> partitions = new HashSet<>(committablePartitions);
+ committablePartitions.clear();
+ newPartitions.values().forEach(partitions::addAll);
+ newPartitions.clear();
Review comment:
Will clear the headMap also cleans the part before the current
checkpoint in `this.newPartitions` ?
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/stream/StreamingFileWriter.java
##########
@@ -134,13 +143,19 @@ public void notifyCheckpointComplete(long checkpointId)
throws Exception {
private void commitUpToCheckpoint(long checkpointId) throws Exception {
helper.commitUpToCheckpoint(checkpointId);
+
+ NavigableMap<Long, Set<String>> newPartitions =
this.newPartitions.headMap(checkpointId, true);
Review comment:
Change to another name to avoid override variable names ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
