fsk119 commented on a change in pull request #14206:
URL: https://github.com/apache/flink/pull/14206#discussion_r530133529
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkStreamRuleSets.scala
##########
@@ -365,6 +365,8 @@ object FlinkStreamRuleSets {
PythonCorrelateSplitRule.INSTANCE,
// merge calc after calc transpose
FlinkCalcMergeRule.INSTANCE,
+ // remove trivial calc
+ FlinkLogicalCalcRemoveRule.INSTANCE,
Review comment:
`Calc_REMOVE` uses the `CalcRemoveRule.Config.DEFAULT` to generate the
remove rule, which captures the `LogicalCalc` rather than `FlinkLogicalCalc`
(`FlinkLogicalCalc` is not a sub class of the `LogicalCalc`).
Sure. I will add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
