tillrohrmann commented on a change in pull request #43: URL: https://github.com/apache/flink-docker/pull/43#discussion_r525945766
########## File path: docker-entrypoint.sh ########## @@ -93,21 +94,41 @@ prepare_job_manager_start() { envsubst < "${CONF_FILE}" > "${CONF_FILE}.tmp" && mv "${CONF_FILE}.tmp" "${CONF_FILE}" } +disable_jemalloc_env() { + local -n _args=$1 + if [ "${_args[0]}" = ${COMMAND_DISABLE_JEMALLOC} ]; then + echo "Disable Jemalloc as the memory allocator" + _args=("${_args[@]:1}") Review comment: isn't `_args` a local variable which should only be valid within the function? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org