twalthr commented on a change in pull request #14111: URL: https://github.com/apache/flink/pull/14111#discussion_r525878851
########## File path: docs/dev/table/sourceSinks.zh.md ########## @@ -193,6 +192,149 @@ for more information. The runtime implementation of a `LookupTableSource` is a `TableFunction` or `AsyncTableFunction`. The function will be called with values for the given lookup keys during runtime. +#### Defining a Dynamic Table Source with Projection Push-Down Review comment: How about we just describe the interfaces in 1 or 2 sentences. Maybe in a table. And link to the corresponding class on Github. It is very difficult to keep docs and interfaces in sync. We should avoid code duplication. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org