echauchot commented on pull request #14096: URL: https://github.com/apache/flink/pull/14096#issuecomment-729026474
> They are different in what configuration they allow from the outside, so things that testcontainers expects to work don't work for some reason. For reference, these are the ES images from the ES docker repo: https://www.docker.elastic.co/r/elasticsearch. But the `5.3.3` image from there also doesn't work out-of-box with what I'm trying to do. I suggest to merge this as is once CI is green and someone else can try and make it work for ES5 if they want to. But I think it's not worth the effort since I'm hoping we can deprecate/remove ES5 soon. Ok thanks for these precisions. I agree spending too much time on making it work for ES5 might not be useful as the end of life of the last ES5.x was 2019-03-11 and it is no more maintained by elastic since version 7.0 is out. LGTM for merging once CI is green. I saw no thread about deprecating/removing ES5 support in the ML so I'll create one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
