[ https://issues.apache.org/jira/browse/FLINK-19656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232760#comment-17232760 ]
Etienne Chauchot commented on FLINK-19656: ------------------------------------------ Hi [~chesnay] I took a look at Flink code and _FrontMetricGroup_ class already provides Metric name character filtering [here|https://github.com/apache/flink/blob/4a6ce272cbb53a683a9c68aa003a0f5464d8fb4d/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/FrontMetricGroup.java#L48] that allows to specify a backend specific delimiter and a backend specific filtering function. Can you explain a bit more " if the delimiter is contained with a given component" ? Thanks > Automatically replace delimiter in metric name components > --------------------------------------------------------- > > Key: FLINK-19656 > URL: https://issues.apache.org/jira/browse/FLINK-19656 > Project: Flink > Issue Type: Improvement > Components: Runtime / Metrics > Reporter: Chesnay Schepler > Priority: Major > Labels: starter > Fix For: 1.12.0 > > > The metric name consists of various components (like job ID, task ID), that > are then joined by a delimiter(commonly {{.}}). > The delimiter isn't just for convention, but also carries semantics for many > metric backends, as they organize metrics based on the delimiter. > This can behave in unfortunate ways if the delimiter is contained with a > given component, as it will now be split up by the backend. > We should automatically filter such occurrences to prevent this from > happening. -- This message was sent by Atlassian Jira (v8.3.4#803005)