gaoyunhaii commented on a change in pull request #14061:
URL: https://github.com/apache/flink/pull/14061#discussion_r524006896
##########
File path: docs/dev/connectors/streamfile_sink.md
##########
@@ -765,6 +765,7 @@ and Flink will throw an exception.
normal job termination (*e.g.* finite input stream) and termination due to
failure, upon normal termination of a job, the last
in-progress files will not be transitioned to the "finished" state.
+TODO I think this is wrong.
Review comment:
Very thanks for the explanation! From the code it seems if the src does
not exists & dest exists, it would skip the file, but if the dest does not
exist, s3 would throw exceptions while Hadoop ignore the error. Thus I'm a bit
confused here that would we still keep the original notes ? it seems the sink
indeed do not throw exception for all the in-progress files not found.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
