tzulitai commented on a change in pull request #14042: URL: https://github.com/apache/flink/pull/14042#discussion_r522733565
########## File path: flink-core/src/main/java/org/apache/flink/core/io/PostVersionedIOReadableWritable.java ########## @@ -62,16 +62,23 @@ public void write(DataOutputView out) throws IOException { */ public final void read(InputStream inputStream) throws IOException { byte[] tmp = new byte[VERSIONED_IDENTIFIER.length]; - inputStream.read(tmp); + int totalRead = 0; Review comment: nit: just for extra readability, could you refactor this reading logic to a separate method? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org