rmetzger commented on a change in pull request #42:
URL: https://github.com/apache/flink-docker/pull/42#discussion_r521302651
##########
File path: 1.11/scala_2.11-java11-debian/docker-entrypoint.sh
##########
@@ -91,21 +91,47 @@ prepare_job_manager_start() {
envsubst < "${CONF_FILE}" > "${CONF_FILE}.tmp" && mv "${CONF_FILE}.tmp"
"${CONF_FILE}"
}
+disable_jemalloc_env() {
Review comment:
The files in the `1.11`, `1.10` and so files on `master` are generated
and should not be modified manually.
`dev-master`, `dev-1.11`, `dev-1.10` contain the templates for the entry
points for the different versions.
I believe we want to add this feature for upcoming releases only. I would
then suggest to make the changes only on `dev-master`. As part of the release
process, these changes will also end up in the `dev-1.12` branch, which we will
use to generate the `1.12/` directory.
Further reading: https://github.com/apache/flink-docker#development-workflow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
