PatrickRen commented on pull request #14022:
URL: https://github.com/apache/flink/pull/14022#issuecomment-725170958


   Hi @becketqin , @Sxnan reproduced an instance of failure locally and I 
investigated the trace-level log. The response of the first `listTopics` 
request only contained topic-1, and the latter two `listTopics` requests 
successfully retrieved both topic-1 and pattern-topic. I think this is because 
the second topic was not ready when the first test case was running. Your 
changes look good to me. 
   
   Also there's a typo in the test case:
   
https://github.com/apache/flink/blob/592c2e7ab392cc0bb368d630eff0a89dd5ccf2a4/flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/subscriber/KafkaSubscriberTest.java#L86
   I think NUM_PARTITIONS should be used instead of NUM_RECORDS_PER_PARTITION, 
although their values are identical. 
   
   Thanks~ 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to