[ 
https://issues.apache.org/jira/browse/FLINK-20020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229021#comment-17229021
 ] 

Nicholas Jiang commented on FLINK-20020:
----------------------------------------

[~kkl0u], I agree with your point above mentioned that making the exception 
uniform and part of the contract like the behaviour of the EmbeddedJobClient 
which throws an UnsuccessfulExecutionException including the status of the 
application. For the JobClient, the getJobExecutionResult() should tell users 
the status of the application when throwing the Exception.
And if you don't have time to uniform this, I would like to work for this issue.

> Make UnsuccessfulExecutionException part of the 
> JobClient.getJobExecutionResult() contract.
> -------------------------------------------------------------------------------------------
>
>                 Key: FLINK-20020
>                 URL: https://issues.apache.org/jira/browse/FLINK-20020
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client / Job Submission
>    Affects Versions: 1.12.0
>            Reporter: Kostas Kloudas
>            Priority: Major
>
> Currently, different implementations of the {{JobClient}} throw different 
> exceptions. The {{ClusterClientJobClientAdapter}} wraps the exception from 
> the {{JobResult.toJobExecutionResult()}} into a 
> {{ProgramInvocationException}}, the {{MiniClusterJobClient}} simply wraps it 
> in a {{CompletionException}} and the {{EmbeddedJobClient}} wraps it into an 
> {{UnsuccessfulExecutionException}}. 
> With this issue I would like to propose making the exception uniform and part 
> of the contract and as a candidate I would propose the behaviour of the 
> {{EmbeddedJobClient}} which throws an {{UnsuccessfulExecutionException}}. The 
> reason is that this exception also includes the status of the application.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to