JingsongLi commented on a change in pull request #13957:
URL: https://github.com/apache/flink/pull/13957#discussion_r519122574



##########
File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
##########
@@ -251,6 +258,14 @@ private RowDataPartitionComputer partitionComputer() {
                                //noinspection unchecked
                                return 
Optional.of(FileInputFormatCompactReader.factory((FileInputFormat<RowData>) 
format));
                        }
+               } else if (deserializationFormat != null) {
+                       // NOTE, we need pass full format types to 
deserializationFormat
+                       DeserializationSchema<RowData> decoder = 
deserializationFormat.createRuntimeDecoder(
+                                       createSourceContext(context), 
getFormatDataType());
+                       int[] projectedFields = IntStream.of(0, 
schema.getFieldCount()).toArray();

Review comment:
       I'll add Json Compaction test




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to