[ https://issues.apache.org/jira/browse/FLINK-19698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227250#comment-17227250 ]
Xintong Song commented on FLINK-19698: -------------------------------------- Hi [~becket_qin], I find the fix for this issue has been merged into the master branch, but not yet into the release-1.11 branch. Anything blocks it from being merged to 1.11? > Add close() method and onCheckpointComplete() to the Source. > ------------------------------------------------------------ > > Key: FLINK-19698 > URL: https://issues.apache.org/jira/browse/FLINK-19698 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common > Affects Versions: 1.11.2 > Reporter: Jiangjie Qin > Assignee: Jiangjie Qin > Priority: Blocker > Labels: pull-request-available > Fix For: 1.12.0, 1.11.3 > > > Right now there are some caveats to the new Source API. From the > implementation of some connectors. We would like to make the following > improvements to the current Source API. > # Add the following method to the {{SplitReader}} API. > {{public void close() throws Exception;}} > This method allows the SplitReader implementations to be closed properly when > the split fetcher exits. > # Add the following method to the {{SourceReader}} API. > {{public void checkpointComplete(long checkpointId);}} > This method allows the {{SourceReader}} to take some cleanup / reporting > actions when a checkpoint has been successfully taken. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)