SteNicholas commented on pull request #13853: URL: https://github.com/apache/flink/pull/13853#issuecomment-721775434
> First of all I think your PR does not cover all the cases. You're disabling only the periodic watermarks. We should do the same for the punctuated watermarks (`onEvent`). I think the best way to do it would be to just create a different `watermarkGenerator`. Instead of calling `watermarkStrategy.createWatermarkGenerator` you could create a `NoOpWatermarkGenerator`. > > Moreover, could you go over the whole PR and fix indentations of arguments? The argument list should have one more level of indentation than the method body. @dawidwys , thanks for your detailed suggestions for the punctuated watermarks. It was my mistake that missed this test case for the punctuated watermarks. I have followed your comments to add `NoOpWatermarkGenerator`. If you are available, please help to review again, thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
