aljoscha commented on a change in pull request #13828:
URL: https://github.com/apache/flink/pull/13828#discussion_r514195600
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/SourceTransformationTranslator.java
##########
@@ -36,26 +38,29 @@
* @param <OUT> The type of the elements that this source produces.
*/
@Internal
-public class SourceTransformationTranslator<OUT>
- extends SimpleTransformationTranslator<OUT,
SourceTransformation<OUT>> {
+public class SourceTransformationTranslator<OUT, SplitT extends SourceSplit,
EnumChkT>
+ extends SimpleTransformationTranslator<OUT,
SourceTransformation<OUT, SplitT, EnumChkT>> {
@Override
protected Collection<Integer> translateForBatchInternal(
- final SourceTransformation<OUT> transformation,
+ final SourceTransformation<OUT, SplitT, EnumChkT>
transformation,
final Context context) {
- return translateInternal(transformation, context);
+
+ return translateInternal(transformation, context, false /* emit
progressive watermarks */);
}
@Override
protected Collection<Integer> translateForStreamingInternal(
- final SourceTransformation<OUT> transformation,
+ final SourceTransformation<OUT, SplitT, EnumChkT>
transformation,
final Context context) {
- return translateInternal(transformation, context);
+
+ return translateInternal(transformation, context, true /* emit
progressive watermarks */);
}
private Collection<Integer> translateInternal(
- final SourceTransformation<OUT> transformation,
- final Context context) {
+ final SourceTransformation<OUT, SplitT, EnumChkT>
transformation,
+ final Context context,
+ boolean emitProgressiveWatermarks) {
Review comment:
It is to show that we emit watermarks as we go. Even in BATCH mode we
still emit the final watermark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
