[ 
https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221317#comment-17221317
 ] 

Aljoscha Krettek commented on FLINK-19671:
------------------------------------------

Those are more arguments for having an opinionated, enforced coding style. You 
shouldn't have to worry about coding style/formatting at all in a PR if you 
have a good tool for that. Unfortunately, the discussion about that seems to 
have died.

Without that, I'll keep using the EditorConfig setup because it's the closest 
thing I can get to a good formatter with configuration in a text file that I 
can version with code. Plus it pleases our Checkstyle and I won't worry about a 
style guide that requires humans to check/apply it by hand.

> Update EditorConfig file to be useful
> -------------------------------------
>
>                 Key: FLINK-19671
>                 URL: https://issues.apache.org/jira/browse/FLINK-19671
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Major
>              Labels: pull-request-available
>
> We should update our {{.editorconfig}} file to format Java code according to 
> a style that passes our checkstyle rules and also applies our import 
> ordering. This will greatly simplify development because developers can just 
> "re-format code" in IntelliJ and be done with it.
> See the ML discussion for more background: 
> https://lists.apache.org/thread.html/r481bb622410718cd454d251b194c7c1ad358e5d861fdacc9a4be3b5b%40%3Cdev.flink.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to