danny0405 commented on a change in pull request #13763:
URL: https://github.com/apache/flink/pull/13763#discussion_r512367627



##########
File path: 
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverter.java
##########
@@ -417,4 +431,11 @@ public static LogicalType 
extractValueTypeToAvroMap(LogicalType type) {
                }
                return builder;
        }
+
+       /** Returns schema with nullable true. */
+       private static Schema nullableSchema(Schema schema) {

Review comment:
       They are for different purpose but i think we can use `nullableSchema` 
altogether.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to