kezhuw opened a new pull request #13776:
URL: https://github.com/apache/flink/pull/13776


   ## What is the purpose of the change
   Fix spurious `InputStatus.END_OF_INPUT` from `SourceReaderBase.pollNext` 
caused by split reader exception.
   
   ## Brief change log
   * Modify `SourceReaderBaseTest.testExceptionInSplitReader` to assert that 
`SourceReaderBase.pollNext` will not return `InputStatus.END_OF_INPUT` in case 
of split reader exception.
   * Move `exceptionHandler` from `ThrowableCatchingRunnable` to 
`SplitFetcher.errorHandler`.
   * Construct happens-before relation between `SplitFetcher.errorHandler` and 
`SplitFetcher.shutdownHook`.
   * Check `SplitFetcherManager.uncaughtFetcherException` before returning 
`InputStatus.END_OF_INPUT`.
   
   ## Verifying this change
   
   This change modifies tests and can be verified as follows:
   - `SourceReaderBaseTest.testExceptionInSplitReader`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to