tillrohrmann commented on a change in pull request #13711:
URL: https://github.com/apache/flink/pull/13711#discussion_r510221384
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/retriever/impl/RpcGatewayRetriever.java
##########
@@ -42,24 +44,26 @@
private final RpcService rpcService;
private final Class<T> gatewayType;
private final Function<UUID, F> fencingTokenMapper;
-
- private final int retries;
- private final Time retryDelay;
+ private final RetryStrategy retryStrategy;
public RpcGatewayRetriever(
RpcService rpcService,
Class<T> gatewayType,
Function<UUID, F> fencingTokenMapper,
int retries,
Time retryDelay) {
- this.rpcService = Preconditions.checkNotNull(rpcService);
+ this(rpcService, gatewayType, fencingTokenMapper, new
FixedRetryStrategy(retries, retryDelay));
Review comment:
I think it should be fine to use an exponential backoff strategy with an
initial timeout of `10ms` and with a max timeout of `50ms` and `12` attempts. I
will try to do it based on your PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
