rmetzger commented on a change in pull request #13668: URL: https://github.com/apache/flink/pull/13668#discussion_r506908873
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/ExternalSorter.java ########## @@ -230,6 +218,20 @@ public void close() { } } + private void closeThread(StageRunner sortThread, String threadName) { Review comment: ```suggestion private void closeThread(StageRunner thread, String threadName) { ``` ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/ExternalSorter.java ########## @@ -230,6 +218,20 @@ public void close() { } } + private void closeThread(StageRunner sortThread, String threadName) { + try { + sortThread.close(); Review comment: ```suggestion thread.close(); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org