wangxlong commented on a change in pull request #13669:
URL: https://github.com/apache/flink/pull/13669#discussion_r506781235



##########
File path: 
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java
##########
@@ -147,7 +147,7 @@ public void eval(Object... keys) {
                        }
                }
 
-               for (int retry = 1; retry <= maxRetryTimes; retry++) {
+               for (int retry = 0; retry <= maxRetryTimes; retry++) {

Review comment:
       `sink.max-retries` configuration in `JdbcBatchingOutputFormat` is 
similar with this, could you also have a change?
   
   BTW, Commit message should contain issue id etc, following 
   
[https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html](https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to