zentol commented on a change in pull request #13640:
URL: https://github.com/apache/flink/pull/13640#discussion_r506294172
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/util/MetricUtilsTest.java
##########
@@ -79,6 +84,23 @@ public void testNonHeapMetricsCompleteness() {
Assert.assertNotNull(nonHeapMetrics.get(MetricNames.MEMORY_MAX));
}
+ @Test
+ public void testMetaspaceCompleteness() {
+ final InterceptingOperatorMetricGroup metaspaceMetrics = new
InterceptingOperatorMetricGroup();
+ final InterceptingOperatorMetricGroup parentMetrics = new
InterceptingOperatorMetricGroup() {
+ @Override
+ public MetricGroup addGroup(String name) {
+ return metaspaceMetrics;
Review comment:
Could we not return `this`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
