rkhachatryan commented on a change in pull request #13565: URL: https://github.com/apache/flink/pull/13565#discussion_r503730533
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java ########## @@ -531,6 +527,30 @@ private void dispose(boolean releaseState, CheckpointsCleaner checkpointsCleaner } } + @Override + public void discard() { + synchronized (lock) { + if (stateDiscarded) { + Preconditions.checkState(discarded, "Checkpoint should be disposed before being discarded"); + return; + } else { + stateDiscarded = true; + } + } Review comment: Yes, previously it wasn't needed. I added it to avoid future mistakes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org