[ https://issues.apache.org/jira/browse/FLINK-19384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212776#comment-17212776 ]
Jiangjie Qin commented on FLINK-19384: -------------------------------------- [~sewen] Thanks for catching this. Throwing `Exception` in all the three cases sounds a good idea. It gives the source developer a clear indication on what to do if something goes wrong. > Source API exception signatures are inconsistent > ------------------------------------------------ > > Key: FLINK-19384 > URL: https://issues.apache.org/jira/browse/FLINK-19384 > Project: Flink > Issue Type: Bug > Components: API / Core > Affects Versions: 1.11.0, 1.11.1, 1.11.2 > Reporter: Stephan Ewen > Priority: Blocker > Fix For: 1.12.0 > > > The methods in {{org.apache.flink.api.connector.source.Source}} have > inconsistent exception signatures: > - the methods to create reader and enumerator do not throw a checked > exception > - the method to restore an enumerator throws an {{IOException}}. > Either all methods should allow throwing checked IOExceptions or all methods > should not allo any checked exceptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)