wuchong commented on a change in pull request #13543:
URL: https://github.com/apache/flink/pull/13543#discussion_r502733151
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonToRowDataConverters.java
##########
@@ -300,22 +305,12 @@ private JsonToRowDataConverter
createArrayConverter(ArrayType arrayType) {
};
}
- private JsonToRowDataConverter createMapConverter(LogicalType type) {
- LogicalType keyType;
- LogicalType valueType;
- if (type instanceof MapType) {
- MapType mapType = (MapType) type;
- keyType = mapType.getKeyType();
- valueType = mapType.getValueType();
- } else {
- MultisetType multisetType = (MultisetType) type;
- keyType = multisetType.getElementType();
- valueType = new IntType();
- }
+ private JsonToRowDataConverter createMapConverter(
+ String typeSummary, LogicalType keyType, LogicalType valueType)
{
Review comment:
Add one more indent for parameters if they start a new line.
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonToRowDataConverters.java
##########
@@ -300,22 +305,12 @@ private JsonToRowDataConverter
createArrayConverter(ArrayType arrayType) {
};
}
- private JsonToRowDataConverter createMapConverter(LogicalType type) {
- LogicalType keyType;
- LogicalType valueType;
- if (type instanceof MapType) {
- MapType mapType = (MapType) type;
- keyType = mapType.getKeyType();
- valueType = mapType.getValueType();
- } else {
- MultisetType multisetType = (MultisetType) type;
- keyType = multisetType.getElementType();
- valueType = new IntType();
- }
+ private JsonToRowDataConverter createMapConverter(
+ String typeSummary, LogicalType keyType, LogicalType valueType)
{
if (!LogicalTypeChecks.hasFamily(keyType,
LogicalTypeFamily.CHARACTER_STRING)) {
throw new UnsupportedOperationException(
"JSON format doesn't support non-string as key
type of map. " +
- "The map type is: " +
type.asSummaryString());
+ "The map type is: " + typeSummary);
Review comment:
```suggestion
"The type is: " + typeSummary);
```
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/RowDataToJsonConverters.java
##########
@@ -218,14 +225,13 @@ private RowDataToJsonConverter
createArrayConverter(ArrayType type) {
};
}
- private RowDataToJsonConverter createMapConverter(MapType type) {
- LogicalType keyType = type.getKeyType();
+ private RowDataToJsonConverter createMapConverter(
+ String typeSummary, LogicalType keyType, LogicalType valueType)
{
if (!LogicalTypeChecks.hasFamily(keyType,
LogicalTypeFamily.CHARACTER_STRING)) {
throw new UnsupportedOperationException(
"JSON format doesn't support non-string as key
type of map. " +
- "The map type is: " +
type.asSummaryString());
+ "The map type is: " + typeSummary);
Review comment:
```suggestion
"The type is: " + typeSummary);
```
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/RowDataToJsonConverters.java
##########
@@ -218,14 +225,13 @@ private RowDataToJsonConverter
createArrayConverter(ArrayType type) {
};
}
- private RowDataToJsonConverter createMapConverter(MapType type) {
- LogicalType keyType = type.getKeyType();
+ private RowDataToJsonConverter createMapConverter(
+ String typeSummary, LogicalType keyType, LogicalType valueType)
{
Review comment:
Add one more indent for parameters if they start a new line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
